search

valtech-sd / amqp-cacoon

AmqpCacoon is an abstraction around node-amqp-connection-manager that provides a simple interface with flow control, retries, reconnects, and more included out of the box.
MIT License
5 stars 4 forks source link

Drain event on publish (comes via the underlying node-amqp-connection-manager dependency) #20

Open EricWasTakenMJD opened 3 years ago

EricWasTakenMJD commented 3 years ago

Note that dependency: node-amqp-connection-manager currently has a reported bug (possibly?) and does not currently handle drain events. While it guarantees receipt of all published messages, it does not resend failed messages when a drain emit is fired. This would ideally be fixed in the library and allow us to resend on drain as we did previously (instead of on a fixed time interval).

See https://github.com/jwalton/node-amqp-connection-manager/issues/129 for the dependency issue.

Is this causing issues with AMQP Cacoon also?

Requires research and is left as a possible future fix for AMQPCacoon.

EricWasTakenMJD commented 3 years ago

This is possibly fixed in https://github.com/jwalton/node-amqp-connection-manager/releases/tag/v3.2.3 - at least it's referenced there as resolved.