PPAA-423 Update to receive other loggers

valtech-sd / amqp-cacoon

AmqpCacoon is an abstraction around node-amqp-connection-manager that provides a simple interface with flow control, retries, reconnects, and more included out of the box.

MIT License

5 stars 4 forks source link

PPAA-423 Update to receive other loggers #37

Closed ignacio-alonso closed 2 years ago

ignacio-alonso commented 2 years ago

Update AMQP Caccon to receive other loggers

Changes

[x] added ILogger interface
[x] updated tests (removed log4js)
[x] removed log4js from package.json
[x] updated version in package.json
[x] updated package-lock.json using node version 16.7

Not changed

passing a logger was already optional
the example keeps using log4js

How to test

npm run test
run the example
You should be able to instantiate the AmqpCaccon class passing different loggers.

EricWasTakenMJD commented 2 years ago

Looks good. @daniellmorris also reviewed.

Changes before merging and release:

[x] Add something to the readme on how to use Log4js and also TSlog as examples.

daniellmorris commented 2 years ago

:tada: This PR is included in version 3.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: