search

valtech / aem-easy-content-upgrade

AEM Easy Content Upgrade simplifies content migrations in AEM projects
Other
61 stars 25 forks source link

Feature/update to groovy 4.x #205

Closed royteeuwen closed 1 year ago

royteeuwen commented 1 year ago

This version contains the latest Groovyconsole, which works on Groovy 4.x, supporting things like java lambda's etc..

royteeuwen commented 1 year ago

Not sure why the build fails on Sonar? This is not something I changed

royteeuwen commented 1 year ago

@nhirrle can you look at this?

nhirrle commented 1 year ago

@nhirrle can you look at this?

Sure, will have a look. Thanks a lot for your contribution!

nhirrle commented 1 year ago

Not sure why the build fails on Sonar? This is not something I changed

Fixed. Was some permission issue on sonar side, sorry for that

nhirrle commented 1 year ago

Hi @royteeuwen

I checked out the branch and tested further. On Java 11 it works fine, haven't found any issues so far. Great! Unfortunately the groovy-bundle doesn't start with Java8 which could be an issue for some clients on AEM 6.5 . What do you think on this? I would like to avoid producing another artifact just for java8 where we bundle an old groovy version but if we have to, hopefully only for aem-on prem, not 100% sure if AEMaaCS is always on Java11...

Let me know about your thoughts.

royteeuwen commented 1 year ago

Hey @nhirrle , Thats bizar, seeing as JDK 8 should be supported: https://groovy-lang.org/releasenotes/groovy-4.0.html#Groovy4.0-requirements

AEMaaCS is always running on Java11, so creating a release 7.0.0 which is only compatible with JDK11 AEM 6.5 and AEMaaCS is (for me) an option, but I will first check if I cant get it working in JDK 8.

royteeuwen commented 1 year ago

@nhirrle I have created a new PR for groovy console which will be compiled with Java 8, seeing as all code is in groovy anyway I wont lose any features ;)