search

valtech / aem-easy-content-upgrade

AEM Easy Content Upgrade simplifies content migrations in AEM projects
Other
61 stars 26 forks source link

No information in logs which script being run by install hook #25

Closed pun-ky closed 5 years ago

pun-ky commented 5 years ago

I captured following logs

18.09.2018 08:28:08.428 *INFO* [qtp607693070-1894] de.valtech.aecu.core.installhook.AecuInstallHook Executing in phase PREPARE
18.09.2018 08:28:08.433 *INFO* [qtp607693070-1894] de.valtech.aecu.core.installhook.AecuInstallHook Executing in phase INSTALLED
18.09.2018 08:28:08.449 *INFO* [qtp607693070-1894] com.icfolson.aem.groovy.console.extension.impl.DefaultExtensionService binding variable log is currently bound to value Logger[groovyconsole], overriding with value = Logger[groovy
console]
18.09.2018 08:28:08.450 *INFO* [qtp607693070-1894] com.icfolson.aem.groovy.console.extension.impl.DefaultExtensionService binding variable session is currently bound to value com.adobe.granite.repository.impl.CRX3SessionImpl@259dbf
08, overriding with value = com.adobe.granite.repository.impl.CRX3SessionImpl@259dbf08
18.09.2018 08:28:08.450 *INFO* [qtp607693070-1894] com.icfolson.aem.groovy.console.extension.impl.DefaultExtensionService binding variable slingRequest is currently bound to value de.valtech.aecu.core.service.GroovyConsoleRequest@b
d620d0, overriding with value = de.valtech.aecu.core.service.GroovyConsoleRequest@bd620d0
18.09.2018 08:28:08.450 *INFO* [qtp607693070-1894] com.icfolson.aem.groovy.console.extension.impl.DefaultExtensionService binding variable pageManager is currently bound to value com.day.cq.wcm.core.impl.PageManagerImpl@2ac06e41, o
verriding with value = com.day.cq.wcm.core.impl.PageManagerImpl@2ac06e41
18.09.2018 08:28:08.450 *INFO* [qtp607693070-1894] com.icfolson.aem.groovy.console.extension.impl.DefaultExtensionService binding variable resourceResolver is currently bound to value org.apache.sling.resourceresolver.impl.Resource
ResolverImpl@87d8c4f, overriding with value = org.apache.sling.resourceresolver.impl.ResourceResolverImpl@87d8c4f
18.09.2018 08:28:08.450 *INFO* [qtp607693070-1894] com.icfolson.aem.groovy.console.extension.impl.DefaultExtensionService binding variable queryBuilder is currently bound to value com.day.cq.search.impl.builder.QueryBuilderImpl@16c
64079, overriding with value = com.day.cq.search.impl.builder.QueryBuilderImpl@16c64079
18.09.2018 08:28:08.450 *INFO* [qtp607693070-1894] com.icfolson.aem.groovy.console.extension.impl.DefaultExtensionService binding variable nodeBuilder is currently bound to value com.icfolson.aem.groovy.extension.builders.NodeBuild
er@405017b7, overriding with value = com.icfolson.aem.groovy.extension.builders.NodeBuilder@7a3a6fcd
18.09.2018 08:28:08.451 *INFO* [qtp607693070-1894] com.icfolson.aem.groovy.console.extension.impl.DefaultExtensionService binding variable pageBuilder is currently bound to value com.icfolson.aem.groovy.extension.builders.PageBuild
er@53a1a4ad, overriding with value = com.icfolson.aem.groovy.extension.builders.PageBuilder@375a5562
18.09.2018 08:28:08.451 *INFO* [qtp607693070-1894] com.icfolson.aem.groovy.console.extension.impl.DefaultExtensionService binding variable bundleContext is currently bound to value org.apache.felix.framework.BundleContextImpl@306e7
8b0, overriding with value = org.apache.felix.framework.BundleContextImpl@306e78b0
18.09.2018 08:28:08.572 *WARN* [qtp607693070-1894] org.apache.jackrabbit.oak.query.QueryImpl Traversal query (query without index): SELECT * FROM [cq:PageContent] AS s WHERE ISDESCENDANTNODE([/content/example]); consider creating a
n index
18.09.2018 08:28:08.575 *INFO* [qtp607693070-1894] groovyconsole Migrating page: /content/example
18.09.2018 08:28:08.575 *INFO* [qtp607693070-1894] groovyconsole Migrating page: /content/example/en-us
18.09.2018 08:28:08.576 *WARN* [qtp607693070-1894] org.apache.jackrabbit.oak.query.QueryImpl Traversal query (query without index): SELECT * FROM [cq:PageContent] AS s WHERE ISDESCENDANTNODE([/content/example-demo]); consider creat
ing an index
18.09.2018 08:28:08.577 *INFO* [qtp607693070-1894] groovyconsole Migrating page: /content/example-demo
18.09.2018 08:28:08.577 *INFO* [qtp607693070-1894] groovyconsole Migrating page: /content/example-demo/en-us
18.09.2018 08:28:08.633 *INFO* [qtp607693070-1894] de.valtech.aecu.core.installhook.AecuInstallHook Executing in phase END

and there is absolutely no info that the output "Migrating page ..." is e.g coming from script "/etc/groovyconsole/scripts/aecu/example/migrate.groovy".

This definitely must be improved for better verbosity.

pun-ky commented 5 years ago

What is more, that script path should occur in logs regardless it is being run by hook or manually.

gruberrolandvaltech commented 5 years ago

Yes, we will add some more logging here.

pun-ky commented 5 years ago

How about logging before and after? 😉 Scripts may run very long...

pun-ky commented 5 years ago

Mislooked. It's fine