search

valters-tomsons / Spectabis

A modern PCSX2 Frontend.
https://spectabis.github.io/
GNU General Public License v3.0
116 stars 19 forks source link

Changed stuff around the global config emuDir #27

Closed CyberFoxHax closed 6 years ago

CyberFoxHax commented 6 years ago

instead of removing the executable from the path. Instead i choose to preserve it, why? Because my executable was called "pcsx2-r5350.exe" yet Specabis was unable to pick it up. So the code now preserves the full path to the .exe chosen by the user and in the usages instead uses Path.GetDirectoryName() in cases which you'd need the directory. I'm tempted to change the configuration variable name, but since it's a serialized property it'll probably cause an avalanche of problems across clients.

I also had issues with the command lines of "--cfgpath " pcsx2 pops up with an error that tells me that the command-line is "--cfgpath=" which i corrected, please verify that this is not an old version or something.

I'm still having issues with the interop calls for the configuration system. Was this functional prior to my changes?

valters-tomsons commented 6 years ago

Please use descriptive commit messages next time. I'll test in a few hours, look good thought, great job!

CyberFoxHax commented 6 years ago

Sorry, i shall remember next time

valters-tomsons commented 6 years ago

Hey, it looks like games don't launch on first launch. (If you add games and try to launch them the very first time Spectabis is launched). I know it's not a huge issue, but still, it's buggy as it is already.

Still haven't tested plugins, because I'm mostly running linux now. Did you copy plugins from pcsx2 to /plugins/ directory? I ship those plugins with each Spectabis build manually.

CyberFoxHax commented 6 years ago

boggling with where the settings where stored (%appdata%..\local\WPF_Spectabis). Anyway, found the issue and fixed it.