valters-tomsons / Spectabis

A modern PCSX2 Frontend.
https://spectabis.github.io/
GNU General Public License v3.0
116 stars 19 forks source link

API Overhaul #28

Closed CyberFoxHax closed 5 years ago

CyberFoxHax commented 6 years ago

Turned the API system into a dynamic capacity and with that added functionality for TheGamesDb, IGDB and MobyGames. Additionally the application ships with API Keys embedded into the source code so we wont be bothering our users with it.

But they aren't prevented from doing so. There has been added configuration slots for custom API keys in the config files, and the code properly reads and uses a custom api key, should they be present. But there is no way for the user to actually configure them through our current UI.

Lastly: as a security measure the API keys plaintext has been encrypted in the source, for the purpose of deterring the casual user, but not the determined hacker.

In the future we should consider is how the API's are prioritized? My current solution is use the first in the list and if it fails move to the next. This is the simplest possible solution. For future we should make it more intelligent. Examples:

That should be all. Any issues, light me up!

valters-tomsons commented 5 years ago

Sorry for the delay, this is amazing!