search

valum-framework / valum

Web micro-framework written in Vala
https://valum-framework.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
225 stars 23 forks source link

incompatible with newest vala #175

Closed Matrix-Zhang closed 8 years ago

Matrix-Zhang commented 8 years ago

when use newset vala compile valum, there is an error:

vsgi-chunked-encoder.vala:36.3-36.32: error: overriding method VSGI.ChunkedEncoder.convert' is incompatible with base methodGLib.Converter.convert': incompatible type of parameter 1

arteymix commented 8 years ago

There's a breaking change on convert type annotation, they added a nullable (?) on the input buffer. I'll add a conditional preprocessor directive.

Just to be sure, it's vala 0.31?

arteymix commented 8 years ago

This might pose some problems, because they could be null-check on the buffer now. Would you mind testing the fix-nullable-convert branch?

Matrix-Zhang commented 8 years ago

ok, wait me two days....:)

arteymix commented 8 years ago

This is an issue with Vala and they removed the annotation already. @Matrix-Zhang just wait for the next release ;)

Moreover, 0.31.1 is a development release, so it's not worth fixing it.