valum-framework / valum

Web micro-framework written in Vala
https://valum-framework.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
225 stars 23 forks source link

Meson build #179

Closed arteymix closed 8 years ago

arteymix commented 8 years ago

This PR migrate the build system to Meson.

There's a few blockers:

Upstream details here: https://github.com/mesonbuild/meson/issues/487

arteymix commented 8 years ago

Since Meson require Python 3.4+, we cannot build on Ubuntu 12.04.

Ubuntu 12.04 is still supported until late 2017 (details here).

jpakkane commented 8 years ago

Some minor issues:

add_global_arguments(['-Wall',

You don't need this, Meson will add it for you (except when buildtype is plain, but this usually only happens on distro package builds where -Wall comes in from CFLAGS). Depending on your needs you might also want to increase the default warning level instead of adding extra warnings by hand.

The current spec file does not work the way you expect it to. You might want to swipe a working configure stanza from the sample rpmmacro we have.

arteymix commented 8 years ago

@jpakkane actually, I suppress warnings that cannot be addressed in Vala

I did not see the RPM macros, it's always nice to have :+1: and for the flags, I simply copied what I had in the wscript.

Now, I'm wondering how I will be able to build on the Copr. Do you backport fixes?

On the other hand, I think I will abandon the idea of running Meson on 12.04, because it just seem very difficult to overcome the dependencies.

arteymix commented 8 years ago

The CI is kind of stuck at "Waiting for status to be reported", so I'll reopen the ticket..

codecov-io commented 8 years ago

Current coverage is 54.66%

Merging #179 into master will decrease coverage by 6.59%

@@             master    #179   diff @@
=======================================
  Files            27      23     -4   
  Lines          1027     986    -41   
  Methods           0       0          
  Branches          0       0          
=======================================
- Hits            629     539    -90   
- Misses          398     447    +49   
  Partials          0       0          
  1. 3 files (not in diff) in src/valum were deleted. more
  2. 1 files (not in diff) in src were deleted. more
  3. 7 files (not in diff) in src/vsgi were modified. more
    • Misses +63
    • Hits -55
  4. 1 files (not in diff) in src were modified. more
    • Misses +9
    • Hits +49

Powered by Codecov. Last updated by 7b55ae8...220e353

arteymix commented 8 years ago

I added a custom script for installing bindings and dependency files.

arteymix commented 8 years ago

The 0.32 will introduce helpers to test dependency version and fix feature detection. This should cover the lua example as well.

arteymix commented 8 years ago

From now on, we have to be careful because we are not building on minimal dependencies and there should be some check before releases.

The Docker build still have to be updated.