search

valum-framework / valum

Web micro-framework written in Vala
https://valum-framework.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
225 stars 23 forks source link

vsgi: Rewrite FastCGI I/O streams in C (fix #171) #203

Closed arteymix closed 7 years ago

arteymix commented 7 years ago

The current implementation has non-existent error handling due to missing return-value-on-error semantic in Vala.

arteymix commented 7 years ago

It's working perfectly except for some memory leaks with vsgi_fastcgi_output_stream_new I'll have to debug later.

arteymix commented 7 years ago

This https://github.com/mesonbuild/meson/issues/1407 is causing trouble for the initial build because of the missing Ninja dependency.

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2731149). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #203   +/-   ##
=========================================
  Coverage          ?   62.39%           
=========================================
  Files             ?       40           
  Lines             ?     1367           
  Branches          ?      170           
=========================================
  Hits              ?      853           
  Misses            ?      446           
  Partials          ?       68

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2731149...74d69d1. Read the comment docs.