chebizarro commented 7 years ago

This brings all of the generated namespaces to the same version. No Gir or Typelib is generated so it's still not possible to create a Typelib for a library that has Valum public symbols.

codecov-io commented 7 years ago

Codecov Report

Merging #208 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   61.37%   61.37%           
=======================================
  Files          44       44           
  Lines        1450     1450           
  Branches      178      178           
=======================================
  Hits          890      890           
  Misses        496      496           
  Partials       64       64

Impacted Files	Coverage Δ
src/valum/valum-server-sent-events.vala	`84% <ø> (ø)`	:arrow_up:
src/valum/valum-content-negotiation.vala	`73.46% <ø> (ø)`	:arrow_up:
src/valum/valum-static.vala	`0% <ø> (ø)`	:arrow_up:
src/vsgi/vsgi-cookie-utils.vala	`100% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd501a2...fcb3557. Read the comment docs.

arteymix commented 7 years ago

Looks good.

The typelib and GIR feature will probably just be for VSGI because Valum has a callback-based API that is not really convenient from a binding perspective. I'm looking to using more classes to model middlewares, but that will wait until 0.5.

On the other hand, VSGI is really friendly and I have some work locally that creates Web application in Python and JavaScript. I'll push this once it's all fixed.

I also dropped older compilers versions in 6d075af7f9b6b45dd4d23f0d08ef6ddc550476f7, they were removed from Vala Team PPA.

valum-framework / valum

updated all gir_version attributes to 0.4 #208

Codecov Report