valum-framework / valum

Web micro-framework written in Vala
https://valum-framework.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
226 stars 23 forks source link

Unable to use valum as dependency using meson with readthedocs recipe #242

Closed lennyhans closed 8 months ago

lennyhans commented 1 year ago

Hi! I was trying to build the sample project using meson with subprojects but I faced a problem, the docs suggest that you should put valum dependency in this way

valum = subproject('valum').get_variable('valum')

But after reading the meson docs about subprojects they suggest to

Naming convention for dependency variables

Ideally the dependency variable name should be of _dep form. This way one can just use it without even looking inside build definitions of that subproject.

After changing that everything works

valum = subproject('valum').get_variable('valum_dep')

I think the docs are obsolete, because later I check the code and yeah, there is a file with this valum/docs/getting-started.rst that suggest the action, and also the valum/src/meson.build has the same name.

Thanks for your work!

arteymix commented 8 months ago

I've adjusted the documentation accordingly. The 0.3 series still uses the previous naming scheme.

lennyhans commented 8 months ago

Thanks!