search

valyala / bytebufferpool

Anti-memory-waste byte buffer pool
MIT License
1.19k stars 132 forks source link

*bytebufferpool.ByteBuffer does not implement io.Reader (missing Read method) #17

Open delfer opened 5 years ago

delfer commented 5 years ago

It would be more useful to implement Read method like 'bytes.Buffer'

jjhesk commented 5 years ago

i think there is a serious race detection by having this library when using message bytes serialization

suntong commented 4 years ago

I don't quite understand what @jjhesk actually is trying to say, but I was coming here to ask for the same thing as asked by @delfer.

nanmu42 commented 3 years ago

Hi, I wonder, is there a specific reason to not implement io.Reader on *bytebufferpool.ByteBuffer? Or is a PR welcome?