dciliske commented 4 years ago

So, like the issue that was raised last fall (#16), I need checksum support for frames. The Advanced Compression API adds this capability, so I've added an interface onto it.

codecov[bot] commented 4 years ago

Codecov Report

Merging #25 into master will decrease coverage by 2.76%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   95.37%   92.60%   -2.77%     
==========================================
  Files           5        5              
  Lines         562      622      +60     
==========================================
+ Hits          536      576      +40     
- Misses         16       30      +14     
- Partials       10       16       +6

Impacted Files	Coverage Δ
gozstd.go	`90.24% <66.66%> (-7.61%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3452344...5c0846f. Read the comment docs.

kaxap commented 4 years ago

any news on merging this?

valyala commented 4 years ago

@kaxap , @dciliske , sorry for long delay - I had no time to review the PR :(

I'll try to allocate some time for reviewing it soon.

gaby commented 1 year ago

@valyala Friendly ping 2.5 years later 😂 Any chance you can take a look at this PR?

myxo commented 1 year ago

Hey, any chance this PR to be merged? Checksum support is highly desirable feature.

valyala / gozstd

Added interface for Advanced Compression API #25

Codecov Report