search

vamolessa / verco

A simple Git/Mercurial/PlasticSCM tui client based on keyboard shortcuts
229 stars 13 forks source link

Please include Cargo.lock #19

Closed wezm closed 4 years ago

wezm commented 4 years ago

Attempting to build from the 5.0.0 release tarball with cargo build --release --locked results in an error:

error: the lock file /home/wmoore/Projects/aur/verco/src/verco-5.0.0/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, use the --offline flag.

I use --locked when building an AUR package to ensure that the build is reproducible. It appears that you have not committed the Cargo.lock file. This is recommended for binary packages to ensure others building from source use the same version of dependencies that you used.

vamolessa commented 4 years ago

just merged #20 so will close now!

wezm commented 4 years ago

Awesome! Also thanks for the PR @Alphare.