search

vampire-studios / Randomly-Adding-Anything

MIT License
44 stars 16 forks source link

Fix for a bug when generating Portal Hubs #83

Closed Tz3r0 closed 4 years ago

Tz3r0 commented 4 years ago

Previously when generating Portal Hubs, the method loadStructure from the class JsonConverter was called. Inside this method it should parse the properties of the blocks of the palette. But because of a scope-issue inside nested lambda-expressions the parsed values would be dereferenced before they were saved. Also the code responsible for setting block states inside the placeBlock method of the WorldStructureManipulation class was flawed in a way, that it tried to lookup values in an enum before capitalizing them.

oliviathevampire commented 4 years ago

Have you tested this and seen that it works?

Tz3r0 commented 4 years ago

2020-03-31_19 30 40 2020-03-31_19 32 59

oliviathevampire commented 4 years ago

ah dopeeee! this should also fix ladders in the towers and a lot more! thank you so much!