search

vampiricwulf / tanoshiine

Real-time imageboard in node v14.5.0 and redis
MIT License
5 stars 1 forks source link

Strip Image EXIF #16

Closed vampiricwulf closed 9 years ago

vampiricwulf commented 9 years ago

http://www.imagemagick.org/script/command-line-options.php#strip

bakape commented 9 years ago

This will recompress the image and degrade JPEG quality. Use exiftool instead.

vampiricwulf commented 9 years ago

Another dependency... But that's just pain, it's why I still haven't pulled that piquant stuff.

bakape commented 9 years ago

The beauty of node is it's compatibility with other CLI tools.

vampiricwulf commented 9 years ago

The beauty of node is it's compatibility with other CLI tools.

But the issue is that I already don't know where in doushio's code is the configurations for these CLI tools, nor do I know how to write my own CLI tool into node.

bakape commented 9 years ago

Simply get the absolute path with which (which('ffmpeg', function (bin) { ffmpegBin = bin; });) and then execute with childprocess (child_process.execFile(ffmpegBin, args, opts, function (err, stdout, stderr) {foo...})).

vampiricwulf commented 9 years ago

Where do you think I should put the stripping process? IU.verify_image? IU.process?

bakape commented 9 years ago

Probably best to put it before IU.deduped as a separate method. Should also be skipped for webm.

vampiricwulf commented 9 years ago

32f08850067a6c417daf0d08c0564fe2f22930b2