vamseeachanta / digitalmodel

MIT License
1 stars 0 forks source link

dev | Cathodic Protection | Calculations #32

Open vamseeachanta opened 6 months ago

vamseeachanta commented 6 months ago

Perform CP Calculations sacrificial anode CP calculations:

Final result required is Weight of Anode required. For detailed methodology for sacrificial anode calculations, see below: https://github.com/vamseeachanta/digitalmodel/blob/oct/docs/cathodic_protection/sacrificial_anode.md

For other general CP details, see below: https://github.com/vamseeachanta/digitalmodel/blob/oct/docs/cathodic_protection/literature.md

vamseeachanta commented 6 months ago

@mpydah FYI

vamseeachanta commented 4 months ago

Dear team, basic structure for the code added so far is below. https://github.com/vamseeachanta/digitalmodel/pull/38/files

@mpydah , @saiachanta2728 @samdansk2 @unixwave Please ask questions if any in below comment box so I can respond.

vamseeachanta commented 1 month ago

@samdansk2 Please work in this branch. Added calculations to the same branch. https://github.com/vamseeachanta/digitalmodel/tree/cp_ss Dev:

samdansk2 commented 1 month ago

@vamseeachanta Hello sir , hope you are doing well , As you said

samdansk2 commented 1 month ago

@vamseeachanta

Hello sir , hope you are doing good ,

samdansk2 commented 1 month ago

@vamseeachanta hello sir ,

samdansk2 commented 1 month ago

@vamseeachanta After opening engine file and input yaml file , when I press 12 key Cathodic_protection.py file has not opened sir. Whyy ?

vamseeachanta commented 1 month ago

@samdansk2. Hit F12 in the engine file on any code command i.e where there is a function defined. Hit F12 again. keep playing with it to get a hang of it. See below: https://code.visualstudio.com/docs/editor/editingevolved#:~:text=in%20the%20editor.-,Go%20to%20Definition,a%20symbol%20by%20pressing%20F12.&text=Tip%3A%20You%20can%20jump%20to,with%20Ctrl%2BAlt%2BClick.

samdansk2 commented 1 month ago

@vamseeachanta after debugging test_cathodic_protection file , when i try to debug the cathodic_protection calculation file using debug toolbar option continue (f5) , but debugging is not working sir , nothing comes in call stack field i am attaching the image below , please see it sir

samdansk2 commented 1 month ago

Screenshot (6)

vamseeachanta commented 1 month ago

@samdansk2 , You are trying to run cathodic_protection.py. The code has class and class functions but nothing is ever called in the file.

So running cathodic_protection.py, will only read the file and its functions. It may stop near a function definition if you put abreakpoint. Anything inside function, nothing will happen and no breakpoints will stop. So, you have to call a code to run. The test_basic_cathodic_protection.py will create entry into the code. This is the summary of the problem.

samdansk2 commented 1 month ago

@vamseeachanta hello sir , Again i started from beginning it is giving one error please see it in below image Is it beacause of we install package in wrong directory ( python -m pip install e .) that i have two in desktop digitalmodel and digitalmodel-1

Note : when you said why two digitalmodel repos while we are in a meet I have deleted previous one digitalmodel and kept latest one digitalmodel-1

samdansk2 commented 1 month ago

Screenshot (12)

vamseeachanta commented 1 month ago

sometimes you may need to restart the program/computer. Or there is a genuine reason. We will try on my computer next time..

samdansk2 commented 1 month ago

@vamseeachanta my doubt is real sir , we installed digitalmodel package in wrong old repository , now i have installed using same command ( python -m pip install - e. ) in present working folder ( repo ) it has worked for me . thankyou.

samdansk2 commented 1 month ago

@vamseeachanta Hello sir , hope you are doing well ,

vamseeachanta commented 1 month ago

@samdansk2 , looks good. Continue the rest of the code. Also track the values in the workbook (350106-SC-EN-022-SD-000229-CTR2-0001-Rev0 CP Calculation vs. programming.xls) and fill in the below columns: image

This way, we know how accurate our program is when compared against the workbook.

PS: Do let me know if you are stuck.

samdansk2 commented 1 month ago

@vamseeachanta everything is done sir , only one calculation is pending , seawater_resistivity calculation , we should discuss about it , thankyou .

vamseeachanta commented 1 month ago

Progress:

vamseeachanta commented 1 month ago

Way forward:

vamseeachanta commented 3 weeks ago