van-smith / OPBM

Open Productivity Benchmark
1 stars 0 forks source link

Official Run does not run tests #62

Closed van-smith closed 13 years ago

van-smith commented 13 years ago

Clicking the Official Run link in the dev skin causes the system to reboot and display the last set of results. No tests are run.

van-smith commented 13 years ago

This behavior was duplicated on the same SUT with the simplified skin.

Note that a Trial Run was made before the first Official Run.

ghost commented 13 years ago

What version of Java? What were the results from the restarter.exe window (can you mark them, copy and paste them to a message here)? Were there any dialog messages that popped up? Can you put the c:\users\username\opbm\running\manifest.xml file out on the Z: drive so I can look at it?

ghost commented 13 years ago

If you look at the manifest.xml file, you'll see why it happened. Most likely the system is set to stop on errors, and one of the install scripts had an error and it stopped before it started. The logic right now for failures does not create a results.xml file, so whatever was there last time for results.xml is loaded.

Search for the tag <failure> in the manifest.xml file, and most likely you'll see what was causing.

van-smith commented 13 years ago

I obtained one successful Official Run on the original Core i5 SUT, but I encountered a failure on the Llano SUT. Here is the CMD message:

_ OPBM Restarter Preparing to restart...

Directory: C:\opbm\java\opbm Executing: C:\Program Files\Java\jre6\bin\java.exe -jar opbm.jar -restart

Success. Running 64-bit JVM Java version: 1.6.0_26 JVM home: C:\Program Files\Java\jre6\bin\java.exe Using C:\opbm\java\opbm.\src\resources\xmls\settings.xml Loaded panels.xml Created menus and navigation panels Found main panel Loaded edits.xml Loaded scripts.xml OPBM System Initialization completed successfully Running: Spinup Pause 60 Seconds Spinning up Spinup atom: Launch and Close PowerPoint Spinup atom: Launch and Close Access Spinup atom: Launch and Close Publisher Spinup atom: Launch and Close Word Spinup atom: Launch and Close Excel Pass 1 of 3: Install 7zip Pass 1 of 3: Install Acrobat Reader Pass 1 of 3: Install Chrome Pass 1 of 3: Install Firefox Pass 1 of 3: Install Opera Pass 1 of 3: Install Safari Auto-uninstall: Uninstall 7zip Auto-uninstall: Uninstall Acrobat Reader Auto-uninstall: Uninstall Chrome Auto-uninstall: Uninstall Firefox Auto-uninstall: Uninstall Opera Auto-uninstall: Uninstall Safari Exception in thread "results_viewerloader" java.lang.ArrayIndexOutOfBoundsExcep tion: -1 at java.util.ArrayList.get(Unknown Source) at opbm.common.Tuple.getFifth(Tuple.java:720) at opbm.dialogs.resultsviewer.ResultsViewerLine.getAverageTabScore(Resul tsViewerLine.java:578) at opbm.dialogs.resultsviewer.ResultsViewer.renderScoreboard(ResultsView er.java:187) at opbm.dialogs.resultsviewer.ResultsViewer.render(ResultsViewer.java:14 5) at opbm.Opbm$2.run(Opbm.java:613)

van-smith commented 13 years ago

BTW, the Result Viewer was displayed but was completely blank after the above exception.

ghost commented 13 years ago

The safari install failed.

Please click the 'Gather Debug Info' button on all errors and post the XML file to the Z: drive, or email to me. It has essential information for debugging.

van-smith commented 13 years ago

I reran the Official Run and the error did not reappear.

The harness is becoming much more robust and resilient.

van-smith commented 13 years ago

A similar failure occurred on the Brazos SUT. The CMD output is below. I have copied the debug info to the Z drive into the debug folder.

OPBM Restarter Preparing to restart...

Directory: C:\opbm\java\opbm Executing: C:\Program Files (x86)\Java\jre6\bin\java.exe -jar opbm.jar -restart

Success. Running 32-bit JVM Java version: 1.6.0_26 JVM home: C:\Program Files (x86)\Java\jre6\bin\java.exe Using C:\opbm\java\opbm.\src\resources\xmls\settings.xml Loaded panels.xml Created menus and navigation panels Found main panel Loaded edits.xml Loaded scripts.xml OPBM System Initialization completed successfully Running: Spinup Pause 60 Seconds Spinning up Spinup atom: Launch and Close PowerPoint Spinup atom: Launch and Close Access Spinup atom: Launch and Close Publisher Spinup atom: Launch and Close Word Spinup atom: Launch and Close Excel Pass 1 of 3: Install 7zip Pass 1 of 3: Install Acrobat Reader Pass 1 of 3: Install Chrome Auto-uninstall: Uninstall 7zip Auto-uninstall: Uninstall Acrobat Reader Auto-uninstall: Uninstall Chrome Exception in thread "results_viewer_loader" java.lang.ArrayIndexOutOfBoundsExcep tion: -1 at java.util.ArrayList.get(Unknown Source) at opbm.common.Tuple.getFifth(Tuple.java:720) at opbm.dialogs.resultsviewer.ResultsViewerLine.getAverageTabScore(Resul tsViewerLine.java:578) at opbm.dialogs.resultsviewer.ResultsViewer.renderScoreboard(ResultsView er.java:187) at opbm.dialogs.resultsviewer.ResultsViewer.render(ResultsViewer.java:14 5) at opbm.Opbm$2.run(Opbm.java:613)

ghost commented 13 years ago

This will continue happening on failures (when OPBM is set to stop on failure) until the error handling algorithms I mentioned in email are coded. In each of these cases, the Results Viewer reaches an empty array (with no timing data) and fails. When that happens, the thread terminates and the results are never loaded. This only happens in the event of a failure (or cancellation by the user), or if an entire atom fails on an official run (no retry succeeds) and the harness is not set to stop on errors. All other conditions should be handled correctly today.

I will correct the unexpected exception condition as well by adding a timeout which sets a "Failed to load" label on-screen in the event of an unexpected exception, or if an inordinate period of time has elapsed and the results have not yet been loaded.

ghost commented 13 years ago

The debugInfo file confirms that there was an error installing chrome (it was already installed), and that caused the failure (line 2528).

There is code now which should prevent Chrome from updating itself so the uninstall script works properly now. Can you verify by right-clicking on the SUT's "Google Chrome" "Uninstall Chrome" shortcut that it is pointing to a 12.x version, and not a 13.x version? If so, please manually uninstall the 13.x version, and then it should work.

van-smith commented 13 years ago

Official Run functionality is good except for bug #2. Closing this issue.