search

van-smith / OPBM

Open Productivity Benchmark
1 stars 0 forks source link

initial uninstalls run 5x if application is not found #71

Closed van-smith closed 13 years ago

van-smith commented 13 years ago

When running an Official Run, the initial uninstall cleanup will run 5x if an application is not installed. More than one attempt is probably not necessary.

ghost commented 13 years ago

"Probably not necessary." Is this something you want me to address?

van-smith commented 13 years ago

I was giving you the opportunity for feedback. I cannot see any reason to try five times to uninstall an application that is not on the system, but perhaps you had some reason for this?

ghost commented 13 years ago

It uses the default number of retries per the user setting. There was no other reason.

ghost commented 13 years ago

Solidifying a new protocol to enable the script error keywords "is not installed" at the end of a string ("Program XYZ is not installed") to serve as an indicator that an app is not installed, and if that error condition is reached, to not retry. Other failures will continue to retry the default number of times.

ghost commented 13 years ago

Do you want this to be the case all of the time, or only on the non-run startup/shutdown scripts?

van-smith commented 13 years ago

My concern is primarily during the cleanup phases.

If the user has specified an application uninstall atom as a test to run, then it makes more sense to try multiple times during the actual test before giving up in that it keeps the retry behavior consistent with other tests.

However, whichever uninstall behavior is most expedient and reliable to implement for the testing phase is fine.

ghost commented 13 years ago

Setting it up to only have early-out on cleanup phases.

van-smith commented 13 years ago

Okay.

van-smith commented 13 years ago

Verified.