van-smith / OPBM

Open Productivity Benchmark
1 stars 0 forks source link

benchmark does not restart on reboot on official run #83

Closed jimmacd closed 12 years ago

jimmacd commented 12 years ago

attempted an official run. I am prompted that the system will shut down... it does, system reboots and never restarts the benchmark.

ghost commented 12 years ago

Does the restarter run? Please look at the registry key: HKCU\Software\Microsoft\Windows\CurrentVersion\RunOnce\opbm -- See what it is set to.

Also, is the user the system auto-loads to the same one that started the Official Run?

jimmacd commented 12 years ago

okay... so I came in this morning and saw that I'd inadvertently copied the run directories into directory at the C:\ .... resulting in a rather long path for that registry key. I moved them to a directory with a nice short name and now it works. I'm not sure if the path length (# of chars) is an issue or not. I will report back when this run completes (fingers crossed).

ghost commented 12 years ago

Jim, I am testing this today with a lot of long path, space-in-path, etc. options.

jimmacd commented 12 years ago

I believe there is some historical DOS'ishness hiding in there...

ghost commented 12 years ago

The maximum key length (excluding quote characters) is 255 characters. If you need to have paths that are that long as valid locations from which to run OPBM, I can modify the restarter.exe app to load a text file with parameters, allowing for up to 255 characters to touch the application's directory. Otherwise I can display an error when the path will be too long to execute a reboot on an official run.

Let me know, Jim.

ghost commented 12 years ago

Worked, 253 characters (254 with trailing null): "C:\Users\rick\Desktop\test with space\test with more spaces\making for a very long path\ a \opbm\restarter.exe" "C:\Users\rick\Desktop\test with space\test with more spaces\making for a very long path\ a \opbm" "C:\Program Files\Java\jre7\bin\java.exe" opbm.jar

Did not work, 255 characters (256 with trailing null): "C:\Users\rick\Desktop\test with space\test with more spaces\making for a very long path\ ab \opbm\restarter.exe" "C:\Users\rick\Desktop\test with space\test with more spaces\making for a very long path\ ab \opbm" "C:\Program Files\Java\jre7\bin\java.exe" opbm.jar

When the RunOnce registry key was not executed, it remained populated. When it ran, it was cleared out.

jimmacd commented 12 years ago

No need to support my abberant case... the super long path I had was completely synthetic and a mistake... I was using the github zip file name as a folder and managed to get one inside another... not exactly an expected use case. Good to know though. My run completed in the short directory.

ghost commented 12 years ago

Okay, I'll add the user error dialog for directory paths yielding a restarter string beyond 254 characters in length.

van-smith commented 12 years ago

Verified. Renamed directory path to >255 characters and appropriate failure dialog appeared.