search

van-smith / OPBM

Open Productivity Benchmark
1 stars 0 forks source link

Benchmark finish not behaving as expected #94

Open ldummitt opened 12 years ago

ldummitt commented 12 years ago

When launched via command line (java -jar opbm.jar -official), the benchmark reboots and runs as expected, but once finished presents the results file and the benchmark UI rather than exit the process. For some extra background, in this particular case, there were errors during the run, so not sure if this only occurs in the error case or in all finished cases.

jimmacd commented 12 years ago

I am out of the office with limited access to email. I will return Monday, 10/17/2011

thank you,

Jim MacDonald

ghost commented 12 years ago

Code near OPBM's execution of the "-restart" command was lowering the "running from command line" flag after finishing the benchmark, causing it not to exit.

Should be fixed in the most recent push with opbm.jar, and an update to opbm.java.

van-smith commented 12 years ago

Hi Lucas,

Currently, the Official Run will run to completion and then present the Result Viewer. We need to have a -silent option that will bypass the Result Viewer and continue to the next iteration or return control to the calling process.

I have not tested this option, but you should be able to effectively workaround this problem by executing:

java -jar opbm.jar -scenario(9):opbm

Theoretically, this will run all of the tests in an Official Run, but instead of three iterations, it executes nine iterations.

van-smith commented 12 years ago

I launched the above command and it appears to be working.

van-smith commented 12 years ago

Unfortunately, reboots do not occur before each iteration even though it is specified in the scenario -- this is something that we actually started working on earlier today.

The commandline above should otherwise work like an extended Official Run.

van-smith commented 12 years ago

The "-silent" switch still does not suppress the Result Viewer on an Official Run.

ghost commented 12 years ago

From the command line, or the GUI?

van-smith commented 12 years ago

Is there a "-silent" option from the GUI?

This thread is about the CLI and that is what I was referring to.

ghost commented 12 years ago

I was asking if you had started OPBM with the "-silent" command line switch, with the expectation that it would suppress the Results Viewer after items were launched and run in the GUI.

rick-pritchett commented 12 years ago

The problem is with the -restart switch.

This switch is seldom used except by the restarter during an Official Run (exceptions include the StandaloneRebootTime and StandAloneStartupSettleDown atoms). The switch's purpose is to "restart" an incomplete manifest. After each Official Run reboot, the command "java -jar opbm.jar -restart" is automatically executed. This causes the existing manifest to be reloaded rather than creating a new one. The manifest is reviewed for errors and if none were found it executes the included tests. Unfortunately during this review process it does not tell the rest of the world whether or not the run was initiated from the command line or the GUI. Consequently, by default, when the run is complete it opens up the OPBM GUI and displays the Results Viewer.

I'm currently testing a fix for this. The intent is to close OPBM after a command line initiated Official Run. If an official Run is initiated from the GUI, OPBM will act as it has been with the GUI reinstated and the Results Viewer brought up. I have several more tests to run but so far it looks promising.

ldummitt commented 12 years ago

It has been a while since I have thought about this, but isn't this issue already resolved?

See Rick Hodgkin's previous (10/13/2011) note regarding this issue:

"Code near OPBM's execution of the "-restart" command was lowering the "running from command line" flag after finishing the benchmark, causing it not to exit.

Should be fixed in the most recent push with opbm.jar, and an update to opbm.java."

-----Original Message----- From: rick-pritchett [mailto:reply@reply.github.com] Sent: Monday, December 19, 2011 3:57 PM To: Dummitt, Lucas Subject: Re: [OPBM] Benchmark finish not behaving as expected (#94)

The problem is with the -restart switch.

This switch is seldom used except by the restarter during an Official Run (exceptions include the StandaloneRebootTime and StandAloneStartupSettleDown atoms). The switch's purpose is to "restart" an incomplete manifest. After each Official Run reboot, the command "java -jar opbm.jar -restart" is automatically executed. This causes the existing manifest to be reloaded rather than creating a new one. The manifest is reviewed for errors and if none were found it executes the included tests. Unfortunately during this review process it does not tell the rest of the world whether or not the run was initiated from the command line or the GUI. Consequently, by default, when the run is complete it opens up the OPBM GUI and displays the Results Viewer.

I'm currently testing a fix for this. The intent is to close OPBM after a command line initiated Official Run. If an official Run is initiated from the GUI, OPBM will act as it has been with the GUI reinstated and the Results Viewer brought up. I have several more tests to run but so far it looks promising.

Reply to this email directly or view it on GitHub: https://github.com/van-smith/OPBM/issues/94#issuecomment-3210326

rick-pritchett commented 12 years ago

Apparently the fix was never implemented.

rick-pritchett commented 12 years ago

Pushed code change to close OPBM upon completion of a command line initiated Official Run.