search

van-smith / OPBM

Open Productivity Benchmark
1 stars 0 forks source link

Official Run launched from GUI ends with no results viewer #97

Closed jimmacd closed 13 years ago

jimmacd commented 13 years ago

An official run launched from the GUI used to end with a display of the results viewer... now it doesn't. I pulled up the results viewer and the tests seem to have executed as expected.

I don't mind a "quiet" end but some indication that the benchmark completed successfully or not would be nice.

ldummitt commented 13 years ago

To be more specific, quietly exiting is appropriate for runs launched via command line (since these are likely automation), whereas display of the results viewer is appropriate for runs manually launched within the GUI (user ran and wants feedback when done).

-----Original Message----- From: Jim MacDonald [mailto:reply@reply.github.com] Sent: Friday, October 21, 2011 10:40 AM To: Dummitt, Lucas Subject: [OPBM] Official Run launched from GUI ends with no results viewer (#97)

An official run launched from the GUI used to end with a display of the results viewer... now it doesn't. I pulled up the results viewer and the tests seem to have executed as expected.

I don't mind a "quiet" end but some indication that the benchmark completed successfully or not would be nice.

Reply to this email directly or view it on GitHub: https://github.com/van-smith/OPBM/issues/97

van-smith commented 13 years ago

Jim, Lucas, yes, this is not desired behavior. "Silent" runs should only occur when a -silent switch is used from the commnad line.

Rick is taking today off, but he will work this weekend and should have this fixed by Monday.

van-smith commented 13 years ago

Duplicated this issue on Llano sut with latest code pull. - Kathy

van-smith commented 13 years ago

Duplicated this issue on the corei5 sut with the latest code pull. - Kathy

ghost commented 13 years ago

Jim, this was an un-intended side-effect from an update I made last week to allow the Official Run benchmarks to run continuously on my SUTs looking for the Chrome error.

It's been corrected with the latest commit.

ghost commented 13 years ago

I left a source code line in there which caused the results viewer to be displayed, and then the harness would immediately terminate at the end of an official run. This has been corrected as of this latest push.

jimmacd commented 13 years ago

working now