search

van-smith / OPBM

Open Productivity Benchmark
1 stars 0 forks source link

Results file name needs to be more specific #99

Closed van-smith closed 12 years ago

van-smith commented 13 years ago

If a default name is assigned for the results, the name needs to include the time stamp. - From Kathy

ghost commented 13 years ago

Are you wanting the user-specified name to be tagged to the results.xml file name? The current design specifies the run name is an internal field, and not part of the file name.

van-smith commented 13 years ago

I originally requested for the result file to be named according to the run name given when a run is launched along with a time stamp. If a run is not named then the time stamp alone will differentiate one result set from the next.

The harness currently overwrites the same result file over and over by default and this is undesirable behavior. The user should be able to call up older runs in the result viewer and it should be difficult if not impossible to accidentally overwrite previous results.

The file name should be generated in this format (generated 10.31.2011 @ 11:32PM):

results_20111031_2332_myRunName.xml

ghost commented 13 years ago

Applied. The fix will be pushed later today.

van-smith commented 13 years ago

The Official Run name dialog unnecessarily accepts multiple lines.

ghost commented 13 years ago

I have noticed several issues recently being lumped into other issue reports. If it's a new/separate issue, it should have it's own item, such as the official run dialog accepting multiple lines should not be on the results.xml filename issue.

van-smith commented 13 years ago

Rick, whenever you feel a new bug report should be created, feel free to start one.

van-smith commented 13 years ago

An Official Run made through the GUI was made with the name "kathy 10308" using the most recent code pull from late 10.30.2011. The run failed on the Brazos SUT and the results file name did not include the specified run name.

ghost commented 13 years ago

Please post debug info? And also if the results file was not named appropriately, please copy out the file it did create for the run time so its contents can be examined.

van-smith commented 13 years ago

I posted debug info for the failure early this morning in bug #92.

van-smith commented 13 years ago

I have copied the results files onto Z: in the debug folder. There are two results in the brazos directory. The older file is from last night's bug #92 failure and the second is from a pass a couple of hours ago. Neither result file included the run name given to it.

Also note that the run time for the first run is incorrect. It was a little after midnight and instead of 0_58... it read 24_58...

ghost commented 13 years ago

A fix was applied for the run name (https://github.com/van-smith/OPBM/commit/4fa4ad3a06d262db81600f1ea45ad0c291ba6f7d). When manifest.xml cannot be loaded, the run name will not be tagged on to the end of the results filenames because manifest.xml contains the run name (in the "control" tag area, as opbm.benchmarks.control.run.#name).

The fix posted this morning to address the manifest.xml load failure error should now correct this error as well.

van-smith commented 12 years ago

Verified.