vanIvan / netflix-subtitle-loader

Chrome extension for loading subtitles from Netflix web series.
MIT License
39 stars 7 forks source link

Not working #2

Open nikkii94 opened 4 years ago

nikkii94 commented 4 years ago

Hello! I installed this extension from Chrome Store but when I try to download subtitle but nothing happens. I always get the following error:

netflix-subtitle-downloader.js:127 Uncaught (in promise) TypeError: Cannot destructure property 'titleP' of 'subCache[getMovieID(...)]' as it is undefined.
    at _download (netflix-subtitle-downloader.js:127)
    at HTMLLIElement.downloadThis (netflix-subtitle-downloader.js:153)

netflix-subtitle-downloader.js:101 Uncaught (in promise) TypeError: Cannot read property 'downloadUrls' of undefined
    at processSubInfo (netflix-subtitle-downloader.js:101)
    at processMessage (netflix-subtitle-downloader.js:173)

Can you help solve this? Thank you!

greeven commented 4 years ago

Had the same problem and found the culprit in netflix-subtitle-downloader.js on line 17.

//old line
const WEBVTT = 'webvtt-lssdh-ios8';

// new line
const WEBVTT = 'dfxp-ls-sdh';

This should fix it (I don't use this repo but it seems to use the same underlying javascript.)

Maybe I find the time to make this change directly in this repository. (Haven't done that yet, so it would take me some time now I don't have.)

Hope that helps. ;)

Oh and be aware: the structure of the subtitles file has changed (if you have a consequent script running a regex against it). ;P