vanWittlaer / VanWittlaerWhat3Words

Shopware 6 plugin - amends address forms with w3w field
MIT License
2 stars 2 forks source link

Update the AutoSuggest component with the fixed version of the script #1

Closed ManuCiao closed 1 year ago

ManuCiao commented 1 year ago

Hi @vanWittlaer Would you mind to update these lines to replace 4-latest with this fixed version 4.1.6

https://github.com/vanWittlaer/VanWittlaerWhat3Words/blob/cca8bd94bd84ed13e50d73e552cc53141e2782a6/src/Resources/views/storefront/component/analytics.html.twig#L13-L20

Also, could you remove the what3words key ?key={{ config('VanWittlaerWhatThreeWords.config.apiKey') }} from this script? you can just pass it within the AutoSuggest component.

it would be:

    <script
            type="module"
            src="https://cdn.what3words.com/javascript-components@4.1.6/dist/what3words/what3words.esm.js"
    />
    <script
            nomodule
            src="https://cdn.what3words.com/javascript-components@4.1.6/dist/what3words/what3words.js"
    />
vanWittlaer commented 1 year ago

Thx Manuela,

Please check v1.1.0 for the updated references and removed apikey.

Regards, Benny

ManuCiao commented 1 year ago

Thanks for your update.