Closed felipecrs closed 2 years ago
Sorry, I won't be able to work more on this by today.
@vanackej, I believe the PR is now good to merge now.
Ok, I'll test asap and merge if ok.
Le sam. 5 févr. 2022 à 15:16, Felipe Santos @.***> a écrit :
@vanackej https://github.com/vanackej, I believe the PR is now good to merge now.
— Reply to this email directly, view it on GitHub https://github.com/vanackej/risco-mqtt-local/pull/14#issuecomment-1030632744, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAECPHLQG6VFAMB4FRIIGL3UZUWM3ANCNFSM5NJCHQ2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
Hi,
Just to be sure to understand : How are end users supposed to provide their addon config ?
Because I want them to be able to configure the addon using GUI. My initial issue is that HA config validation is too restrictive and does not support free/values that are required for some of this plugin for customization.
Frigate is an example of an addon using the same technique for configuration.
And something that can be made to help users edit/validate their config in VSCode would be a JSON Schema.
hey @vanackej , its safe to merge, running it already for few days now :-)
@felipecrs , thnx again!
Np!
Thnx!! :-)
If the addon configuration does not provide you enough options, just use your own. There is no shame in that.
Refs https://github.com/vanackej/risco-mqtt-local/issues/1