search

vanackej / risco-mqtt-local

Provide Risco alarm system integration to Home assistant using local TCP communication (no cloud required) and MQTT
MIT License
24 stars 11 forks source link

Customise alarm panel topic #37

Closed markxroberts closed 2 years ago

markxroberts commented 2 years ago

Updated in typescript Two additional configs added: risco_alarm_topic risco_node_id These permit multiple panels to be configured. Rearrangement of mqtt config options so that risco_alarm_topic is used for will. Regex entries amended to permit custom topic Addresses issue #33 by permitting multiple panels, but does not link panels.

markxroberts commented 2 years ago

Agree that would be simpler to have only one configuration option. I made them different as I wasn't sure whether there was a reason that they had been defined differently. Do we need to make the MQTT alarm topic different to the risco-node-id, or could they just be the same?

markxroberts commented 2 years ago

Having tested this, the only risk of this approach is for those with existing installations as it will change both the HA alarm panel name and the MQTT status topic. Separating them allows further panels to be added and maintains backwards compatibility.

markxroberts commented 2 years ago

I'll update my comment above by saying that this change causes significant problems for me. HA tries to duplicate the entities. I can't work out whether this will be a problem for others, but I suspect it will. I wonder whether we ought to offer a configuration option for the alarm panel topic and name as we do for the sensors. This would help to mitigate this problem.

vanackej commented 2 years ago

Hi I want to be able to review and integrate the various features one by one. Last week I cleaned up your work regarding multiple panels support and made some internal code style improvement (style, topics names, ...) : https://github.com/vanackej/risco-mqtt-local/tree/feature/support_multiple_panels

Can you please clean up the git history in your branches and make one commit per feature please ? It would be easier to review and integrate for me

markxroberts commented 2 years ago

Sure. If I make any further contributions, I'll be sure to follow that. To be honest, you're much better at this than me, so I don't think I've got much to offer now.

vanackej commented 2 years ago

Ok, I'll try to pick up the various changes you've made regarding outputs by myself I'm currently working on multi arch setup. Do you have any Raspberry device to test ? I've build multi arch images but I'm not able to test them : https://github.com/vanackej?tab=packages&repo_name=risco-mqtt-local

markxroberts commented 2 years ago

Sorry, don't have a RPi to test. Will try to look at reformatting the outputs changes to fit in with new structure if you like. I'll work to update on a fork of your feature/support multiple panels code.

vanackej commented 2 years ago

released in 0.5.0-beta.1