If users loads the namespace browser from "recent", "bookmarks" or "help" page, we lose their "last visited" namespace

vanadium-archive / browser

Example app: Vanadium namespace browser

BSD 3-Clause "New" or "Revised" License

1 stars 3 forks source link

If users loads the namespace browser from "recent", "bookmarks" or "help" page, we lose their "last visited" namespace #48

Closed aghassemi closed 9 years ago

aghassemi commented 9 years ago

Normally when one comes back to namespace browser, the last namespace they were on is preserved. This behaviour is broken if someone visits recent or bookmarks and then goes to one of the browse views.

afandria commented 9 years ago

I cannot reproduce this. I tried 2 ways.

Visit my sample world area.
Go to bookmarks
Go to the index page => re-routed to sample world area (Notably, the saved 'index' is only updated when visiting a browse route, when browsing into something.)
Visit my sample world area.
Go to bookmarks
Go back to the tree/radial/grid views => still in sample world area

Can you elaborate on this behavior?

aghassemi commented 9 years ago

You directly to https://browser.staging.v.io/#/bookmarks in a fresh browser tab. Notice the namespace is empty ( < home > ) instead of your last visited namespace.

afandria commented 9 years ago

I see it. In that case, this also affects the Help page.

When going through routes other than routes/index.js and routes/browse.js, state.browse.namespace remains unset.

index loads the namespace from the store and then goes to `browse
browse parses namespace from the url and then does browseNamespace to set the namespace.
bookmarks, error, recommendations, and help do not do any of these; they simply preserve the existing namespace, which may not exist.