search

vanallenlab / moalmanac-browser

Web portal interface for browsing the Molecular Oncology Almanac
https://moalmanac.org
GNU General Public License v2.0
1 stars 1 forks source link

Entry submission and admin approval pages #2

Closed ekofman closed 6 years ago

ekofman commented 6 years ago

@brendanreardon Try pulling this branch locally and see if it runs for you!

ekofman commented 6 years ago

@brendanreardon go to /approve to see the approval portal

brendanreardon commented 6 years ago

Submitted assertions will automatically display in the database before being accepted.

brendanreardon commented 6 years ago

Suggested changes from 2/1

  1. Response and Prognosis Boolean columns in the approve page. For approval, one can be null but not both.
  2. Cite text column in the approve page. For reviewers to fill in.
  3. Homepage search filter only by validated in database. Relevant parameters are gene name and therapy name with the query_distinct_column function. May refactor the query_distinct_columns function.
ekofman commented 6 years ago

@brendanreardon Ready for another testy whenever you have a free moment! I think it's about ready to merge in if you don't see anything else you think I should fix. thx!

brendanreardon commented 6 years ago

@ekofman and I looked at the latest pull request and observed the following comments

  1. On the homepage, the gene name search lists all genes non-uniquely
  2. Entering "\" as an element in the submission form breaks the sql database on the submit entry page. Eric hypothesizes that this is because the \" does not end the quotation, and thus all following code is rendered as a single string.
  3. Gene names on the submit entry page displays all genes, approved and unapproved.
ekofman commented 6 years ago

@brendanreardon Alright! Those last two commits should I think make this PR production ready!

brendanreardon commented 6 years ago

I just checked it out and everything looks great! All of the bugs that we found before are resolved and your code looks grand. Pull away, captain!