vanandrew / warpkit

Python library for neuroimaging transforms.
Other
6 stars 2 forks source link

Purpose of `check_temporal_consistency_corr` #11

Closed tsalo closed 6 months ago

tsalo commented 6 months ago

@vanandrew I'm in the process of translating MEDIC into an SDCFlows workflow, but I'm a little confused about check_temporal_consistency_corr. Does that function raise an exception if the phase unwrapping solutions aren't temporally consistent, or does it modify unwrapped_data in place?

vanandrew commented 6 months ago

Hey @tsalo. That function modifies the unwrapped phase data in-place. The main reason is to avoid any memory copies as that function is very memory intensive (it has to keep track of the entire phase dataset which is volume x frames x echos, so it takes up quite a bit of RAM).

tsalo commented 6 months ago

Thanks!