search

vancegroup / vr-jugglua

VR JuggLua: A Framework for VR Applications Combining Lua, OpenSceneGraph, and VR Juggler
Boost Software License 1.0
11 stars 12 forks source link

Don't install markdown source for binary readme #54

Closed rpavlik closed 12 years ago

rpavlik commented 12 years ago

Too confusing.

rpavlik commented 12 years ago

Please take care of this - should just be easy cmake practice.

rpavlik commented 12 years ago

ping

rpavlik commented 12 years ago

For clarification, don't install it on any platform, I think (just completely remove that) - the HTML is good enough for anyone?

Alternately, perhaps we just install it if NOT WIN32 AND NOT APPLE

carlsonp commented 12 years ago

What markdown tool are you using under Linux?

rpavlik commented 12 years ago

I assume you mean the markdown processing tool to convert to HTML. I installed whatever package it suggested when I typed "markdown" and nothing happened :D looks like the name of the package is literally markdown - looks like the perl one. I think discount should also work.

rpavlik commented 12 years ago

OK, so this cleans it up, and actually probably fixes it in almost all cases - the only piece left is: some platforms (unixy, but probably not even apple), we probably want to install the binary readme unprocessed as well, even if they have Markdown. So, there's one "if" statement to extend - you can grab this branch and update this pull request.

carlsonp commented 12 years ago

Something like this?

rpavlik commented 12 years ago

that looks fine as long as the precedence of "not" is higher than "or" - I can't remember. (When in doubt, over-parenthesize.) I tend to forget that there is a variable called UNIX and instead do a "NOT WIN32"

carlsonp commented 12 years ago

Ready to merge?

rpavlik commented 12 years ago

Yep, looks good, thanks!