vancesteven / PlanetProfile

Construct 1D interior structure models based on planetary properties. Self-consistent thermodynamics are used for fluid, rock, and mineral phases. Sound speeds, attenuation, and electrical conductivities are computed as outputs.
https://vancesteven.github.io/PlanetProfile/
Other
18 stars 13 forks source link

WtPct labels for Seawater are too high #30

Closed itsmoosh closed 2 years ago

itsmoosh commented 3 years ago

The labels we use for Seawater are 10x too high. Seawater is 3.5 wt%, and our standard MgSO4 is 10 wt%, so we use 35 and 10 respectively throughout the code, probably for convenience. We should probably change to ppt so that we can continue to use whole numbers in file names. There will be less ambiguity and potential for confusion that way.

itsmoosh commented 2 years ago

This has been fixed in the Python version by exclusively using ppt. Some catches have been used in the Matlab to account for the discrepancy. In future, the Matlab version will copy the Python functionality.