vancesteven / PlanetProfile

Construct 1D interior structure models based on planetary properties. Self-consistent thermodynamics are used for fluid, rock, and mineral phases. Sound speeds, attenuation, and electrical conductivities are computed as outputs.
https://vancesteven.github.io/PlanetProfile/
Other
18 stars 13 forks source link

Planet.Tb_K gets reset during clathrate handling in PlanetProfile.m #45

Open itsmoosh opened 3 years ago

itsmoosh commented 3 years ago

At this line: https://github.com/vancesteven/PlanetProfile/blob/64c9dc95a96998e9cc4842dce3fae8ba236607eb/PlanetProfile.m#L782 Planet.Tb_K is set to a value for T_K that appears to be calculated during clathrate handling. Planet.Tb_K is a run assumption that is set in the PPBody file, and should never be reset during the PlanetProfile() function.

itsmoosh commented 2 years ago

This only affects the Matlab version, and the problem will be removed when the Matlab is caught up to the Python version.