vancesteven / PlanetProfile

Construct 1D interior structure models based on planetary properties. Self-consistent thermodynamics are used for fluid, rock, and mineral phases. Sound speeds, attenuation, and electrical conductivities are computed as outputs.
https://vancesteven.github.io/PlanetProfile/
Other
18 stars 13 forks source link

Indexing error in SummaryTables.py #56

Open itsmoosh opened 1 year ago

itsmoosh commented 1 year ago

https://github.com/vancesteven/PlanetProfile/blob/d99caeaed9a9b53189b41006b7a3c4679f67d760/PlanetProfile/Utilities/SummaryTables.py#L157

This calculation (and probably all others) for layer thicknesses in SummaryTables.py uses the radii of the uppermost and lowermost layers for a particular phase to calculate layer thicknesses. The bottom layer should use the outer radius of the next material, not the outer radius of the bottom layer of the present material. The index of the bottom layer must be increased by 1, but innermost layers will need to account for the extra r = 0 index.