search

vancluever / terraform-provider-acme-old

ACME (Let's Encrypt) Support for Terraform
Other
207 stars 26 forks source link

Upgrade dnsimple provider to support API V2 #25

Closed johnraz closed 6 years ago

johnraz commented 6 years ago

This will allow the usage of API v2 with dnsimple lego provider which aligns with the current dnsimple terraform provider.

johnraz commented 6 years ago

@vancluever do you mind giving this one a look?

vancluever commented 6 years ago

Hey @johnraz, thanks for this.

As there is a lot of work necessary in updating the vendored dependencies pending (as this project has not been updated since July of last year), I'm going to work on updating these dependencies outside of this PR.

I will make sure that DNSimple gets updated as outlined in this PR though so that the changes in this PR effectively make it to the finished product.

Thanks!

johnraz commented 6 years ago

@vancluever thanks for the follow up. I've seen that it has been done in master already - so thanks about that too. As I'm pretty much starting with Go, those commits were interesting to read! 👍