Please review: Week 2 assignment - Google Image Searcher

[vandanab]

Hi Nathan, The week2 assignment, i.e. Google Image Searcher app is completed. Please review the same.

Required:

• User can enter a search query that will display a grid of image results from the Google Image API.
• User can click on "settings" which allows selection of advanced search options to filter results
• User can configure advanced search filters such as:
  • Size (small, medium, large, extra-large)
  • Color filter (black, blue, brown, gray, green, etc...)
  • Type (faces, photo, clip art, line art)
  • Site (espn.com)
• Subsequent searches will have any filters applied to the search results
• User can tap on any image in results to see the image full-screen
• User can scroll down “infinitely” to continue loading more image results (up to 8 pages)

Optional:

• Robust error handling, check if internet is available, handle error cases, network failures
• Use the ActionBar SearchView or custom layout as the query box instead of an EditText
• User can share an image to their friends or email it to themselves
• Replace Filter Settings Activity with a lightweight modal overlay

@thecodepath @nesquena

[codepathreview]

:+1: nice work. A few notes after checking out the code:

• Great work on organizing source code.
• Nice to see you used action bar for searching
• Good job on getting the Share functionality working
• Great job implementing FilterDialogFragment for filters.
• Good job using the ConnectivityManager to check for network availability
• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Consider using Parcelable instead of Serializable(benefits)

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.