Please review: Week 3 assignment - Simple Twitter Client

[vandanab]

Hi Review team, Week 3 assignment, i.e. a basic twitter client is completed. Please take a look.

I was not able to use parcelable (for passing tweet for detail page view) as suggested in the last review, due to time constraints. Will try to use it next time. Also spent a bit more amount of time on the UI than I should have, otherwise would have gotten in the remaining bonus stories. I did not implement the compose in a modal overlay because I did it in last assignment. I could not complete db persistence (with images also saved on the local store). Would try to get it in, in the next assignment.

Completed user stories: Required:

• User can sign in to Twitter using OAuth login
• User can view the tweets from their home timeline
  • User should be displayed the username, name, and body for each tweet
  • User should be displayed the relative timestamp for each tweet "8m", "7h"
  • User can view more tweets as they scroll with infinite pagination
  • Optional: Links in tweets are clickable and will launch the web browser (see autolink)
• User can compose a new tweet
  • User can click a “Compose” icon in the Action Bar on the top right
  • User can then enter a new tweet and post this to twitter
  • User is taken back to home timeline with new tweet visible in timeline
  • Optional: User can see a counter with total number of characters left for tweet

Optional:

• Advanced: User can refresh tweets timeline by pulling down to refresh (i.e pull-to-refresh)
• Advanced: User can open the twitter app offline and see last loaded tweets
  • Tweets are persisted into sqlite and can be displayed from the local DB (Images not saved!)
• Advanced: User can tap a tweet to display a "detailed" view of that tweet
• Advanced: User can select "reply" from detail view to respond to a tweet
• Advanced: Improve the user interface and theme the app to feel "twitter branded"

@thecodepath @nesquena @codepathreview

[vandanab]

There was a gotcha which I took care of and might be worth mentioning in the assignment instructions: For retweeted tweets from your friends which show in the timeline, the original tweet is displayed instead of the retweet, with just the name of the friend who retweeted on the top and the profile picture of the owner of the original tweet. I am assuming most students would have noticed that.

[codepathreview]

:+1: Good work Vandana. A few notes after checking out the code:

• Your attention to UI/UX was impressive.
• Good to see you were able to format the timestamp cleanly
• Good to see you refreshed the timeline after composing a new tweet
• Nice touch with the character count being displayed while the user composes a tweet by using TextWatcher
• Nice to see you used a SwipeRefreshLayout library for easy timeline refreshes
• Good to see you added ActiveAndroid annotations to the models
• Consider adding progress bars to your app whenever a network request goes out

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.