search

vanderbilt-redcap / cross-project-piping-module

Cross-Project Piping pipes from one field in one project into another field in another project. This project does not currently have a support budget that allows responses to issues.
MIT License
11 stars 7 forks source link

fix pipe-all button not working #23

Closed nsonanh closed 1 year ago

nsonanh commented 1 year ago

Explanation is included in comments

mmcev106 commented 1 year ago

@nsonanh, I am most accustomed to code review comments being used mark places where changes might be required. Am I understanding correctly that these comments are only providing added information, and that you believe the code is ready to merge as of the last commit (bf14909)?

mmcev106 commented 1 year ago

Quy Voreinhard says they successfully tested these changes. That plus an answer to my last question might make me increase my comfort level enough to merge this.

nsonanh commented 1 year ago

@nsonanh, I am most accustomed to code review comments being used mark places where changes might be required. Am I understanding correctly that these comments are only providing added information, and that you believe the code is ready to merge as of the last commit (bf14909)?

Yes @mmcev106, these are my explanation as to why I changed the code at those places, and I believe the code is ready to be merged.

mmcev106 commented 1 year ago

I've merged this. I have someone wants to do some testing before we deploy this to our production server or release it to the consortium. I'll keep you posted (likely within a week or so).

mmcev106 commented 1 year ago

@nsonanh, this PR is included in release 1.4.12! Thanks again for your help!

nsonanh commented 1 year ago

@mmcev106 That's great! Thank you for your support!