Move delayModuleExecution to the beginning of sendEmailAlert

vanderbilt-redcap / email-alerts-module

Module to send customized emails alerts after a form/survey is completed to one or several recipients.

MIT License

2 stars 9 forks source link

Move delayModuleExecution to the beginning of sendEmailAlert #13

Closed pbchase closed 4 years ago

pbchase commented 5 years ago

In this PR, I move the call to delayModuleExecution to the beginning of sendEmailAlert so that the testing of rules will also be delayed.

Replicating the bug is hard, but the fix has proven effective on the host where we had the problem.

This PR fixes Issue #12

knil-maloon commented 4 years ago

Hi @pbchase Sorry this skipped my radar! I just merged it. I know as @jasonlones commented, there are some issues between certain modules like the PDF combo and we haven't figured a fix as, if I remember it correctly, we couldn't reproduce it in our servers. I hope that at least with this change some other delay issues will disappear. Thanks for the contribution!