vanderbilt-redcap / email-alerts-module

Module to send customized emails alerts after a form/survey is completed to one or several recipients.
MIT License
3 stars 9 forks source link

Review #51

Closed knil-maloon closed 8 months ago

knil-maloon commented 8 months ago

New variable to avoid looping too much on the queued emails

scottjpearson commented 8 months ago

I'm confused about function isThisAlertCheckedToSendToday. I was assuming it was an array, but you are sending it into a strtotime() function, which requires a string. Is this intended? I couldn't figure out from the code alone and thought I should ask...

knil-maloon commented 8 months ago

isThisAlertCheckedToSendToday

I'm not sure I understand what you mean. What the function does is it checks if the date of alert_last_sent is the same as today as it means the code has already checked all those queued emails and shouldn't do it anymore.