vanderbilt-redcap / mysql-simple-admin

A simple web-based MySQL client that is read-only and REDCap-centric.
MIT License
3 stars 5 forks source link

Removed the total row count feature, since it makes many queries MUCH slower than necessary #6

Closed mmcev106 closed 2 years ago

mmcev106 commented 2 years ago

I think it might be more valuable for queries to be faster than it is for the total row count to be displayed by default. For example, running select * from redcap_data limit 1 should return immediately, but currently never returns (and bogs down the DB) because of the total row count feature. Users can always run a count() query if that's what they want.

If the total row count feature is worth the time to keep, I could change it to one of the following implementations instead of removing it:

mmcev106 commented 2 years ago

@taylorr4, I'm guessing you left this for me to merge/deploy/release. I just created a "v9.9.9" git master based folder on our servers so could test updates in PROD before tagging & releasing to the consortium. I'm glad I did because I needed to make one more change for this to work properly. I'll plan to release a new version in the next week or so after I've tested this a bit. Let me know if you did NOT intend for me to deploy this, or would prefer something other than the "v9.9.9" strategy.

taylorr4 commented 2 years ago

@mmcev106, sure, i wasn't sure if you wanted to merge/deploy/release it, but i figured you did. That's fine if you want to do that. Thanks!

Also, i've been thinking the past couple weeks about just merging this EM directly into REDCap in the next month. Seems like that'd be a good addition, right?

mmcev106 commented 2 years ago

@taylorr4, I think that'd be a great addition. I use it enough these days that I already kind of think of it as part of REDCap.