search

vanderbilt-redcap / seamless-iframes-modules

MIT License
4 stars 0 forks source link

Review of the entire project #1

Closed mmcev106 closed 4 years ago

mmcev106 commented 5 years ago

Any and all feedback is welcome (especially if it's critical).

Just FYI, GitHub requires a pull request in order to create a "review" (they're one in the same). My first commit on the project already contained a lot of lines, so I couldn't recreate a PR that included them with existing commits. In order to review every line, I made two temporary branches, deleted all files on one, reverted that delete commit on the other, then created a PR to merge the revert commit. Quite silly, but it worked... This isn't an issue after the initial commit.

mmcev106 commented 5 years ago

I chose "Add single comment" for the two comments above, as opposed to clicking "Start Review". Feel free to experiment with both options. I'd love to get a feel for both.