Closed chiticariu closed 2 years ago
@chiticariu, thanks for the contribution!
The AppInsights resource we publish telemetry to is one owned by me so I can get anonymous telemetry data for how this script is being used. Deploying out an AppInsights resource doesn't make sense since it would only receive a few pieces of telemetry from the deployment, it's not meant for ongoing telemetry from Sonar.
If you could make the Set-Property-Value
change seperate from the AppInsights change that would be great and I'd love to accept that change.
Thanks!
@vanderby Ok. I will revert changes regarding AppInsight.
Thanks!
@vanderby Can you check now? I find it helpful to have an AppInsight attached to the Sonar web app, to monitor the application. what do you think?
In the vein of keeping the script & template as simple as possible let's remove the AppInsight changes. If people want an AppInsight's resource tied to the web app they can deploy it manually after the fact. I don't think we want to make the assumption all users will want an AppInsight resource.
@vanderby I've removed all my modifications done in azuredeploy.json file
This fix a part from issue #54 regarding sonar.properties transformation, and other issues related to configuration key identification and replacement, that breaks the sonarqube starting process (a configuration key, for example sonar.jdbc.url, will be uncommented and with the same value 4 times)
I've extended the arm template with application insight deployment as well, so that the script HttpPlatformHandlerStartup.ps1 will log events to this instance without manual intervention.