Fixes #5 - Githubissues

vanderlee / php-sentence

Simple text sentence splitting and counting. Supports atleast english, german and dutch, possibly more. If you find it works well enough for your language, please let me know!

MIT License

78 stars 23 forks source link

Fixes #5 #6

Closed nlemoine closed 7 years ago

nlemoine commented 7 years ago

Handle last word beginning with capital
Add test
Fixes typo
Add PHPUnit to composer (dev) and composer script to run the tests

nlemoine commented 7 years ago

Hi @vanderlee,

I stumbled on this issue too. Dirty fix by adding a length check for abbrievation. These are not easy to detect.

Also added some PHPUnit to ease testing and collaborating.

Would be great to add namespace to your very useful library but I didn't want to commit too many thing at a time.

vanderlee commented 7 years ago

Thank you for the fixes