search

vanderlee / phpSyllable

PHP Syllable splitter/counter and Hyphenator for text and HTML. Multi-language, customisable, cached and fast!
http://vanderlee.github.io/phpSyllable/
118 stars 80 forks source link

PHP 7.3 Compatibility ("continue 2") #29

Closed dargmuesli closed 5 years ago

dargmuesli commented 5 years ago

Prevents error ""continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?" with PHP 7.3.

dargmuesli commented 5 years ago

A code coverage drivers seems to be missing.

vanderlee commented 5 years ago

Thanks for the update. I'll see if I can find some spare time to fix some other things and perhaps get some refactoring done on this.

vanderlee commented 5 years ago

Just noticed this actually a bad fix; it should have just been removing the break statements. Since I'm doing a refactoring, I'll hold up on fixing this until that is done (packagist version wasn't bumped yet).

dargmuesli commented 5 years ago

Ok, thank you for the update :)

dargmuesli commented 5 years ago

When do you think that's approximately gonna be possible for you?

vanderlee commented 5 years ago

Sorry, I kinda forgot. It's up now.

dargmuesli commented 5 years ago

Great, thank you! :)

dargmuesli commented 5 years ago

Hey, seems like the continue 2 fix didn't make it into the current release. Could you please push a 1.5.1 including the recent commits?

vanderlee commented 5 years ago

Done. Fix was delayed because Travis-CI is acting strangely, timing out all tests at 10 minutes while they run just fine locally however I try them.

dargmuesli commented 5 years ago

It's because we meant continue 3 instead of continue 2, I guess. 2 only jumps to the outer while, looping forever, and 3 to the outer foreach, that in my understanding provides the next token.

dargmuesli commented 5 years ago

I've opened another pr for this issue :)