vanderschaarlab / temporai

TemporAI: ML-centric Toolkit for Medical Time Series
https://www.temporai.vanderschaar-lab.com/
Apache License 2.0
95 stars 19 forks source link

[Documentation] Train/Test split in tutorials #101

Open JulianKlug opened 9 months ago

JulianKlug commented 9 months ago

Location of the documentation

Tutorial example: https://temporai.readthedocs.io/en/latest/user_guide/usage/tutorial06_treatments.html#Using-a-temporal-treatment-effects-plugin.

tempor.data.dataset module: https://temporai.readthedocs.io/en/latest/api/tempor.data.dataset.html#tempor.data.dataset.BaseDataset.split

Documentation problem

Training and inference is done on the same data in all tutorials.

Suggested fix for documentation

Encourage train / test split in tutorials.

DrShushen commented 9 months ago

Thank you, great point in terms of encouraging sensible use of the software. This will be implemented soon.