vandeseer / easytable

Small table drawing library built upon Apache PDFBox
MIT License
239 stars 91 forks source link

Removed 4 unnecessary stubbings in TextCellTest.java #153

Open ARUS2023 opened 9 months ago

ARUS2023 commented 9 months ago

In our analysis of the project, we observed that 1) 1 stubbing which is created in TextCellTest.prepareForTest but never executed.

2) 3 stubbings are created in TextCellTest.prepareTwoSpanningColumnsOfSizebut never executed by the test TextCellTest.getWidth_cellWithSpanningNoWrapping.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbings.