search

vandeseer / easytable

Small table drawing library built upon Apache PDFBox
MIT License
239 stars 91 forks source link

added repeatable header for overflow tables #166

Closed Chemmic closed 2 months ago

Chemmic commented 2 months ago

Hey,

I've added a new class called "OverflowOnSamePageRepeatableHeaderTableDrawer". The name is kinda long, maybe it should be changed.

I kinda mixed @vandeseer's "RepeatedHeaderTableDrawer" and "OverflowOnSamePageTableDrawer" together. It allows tables which overflows on the same page to have repeatable headers as well.

PS: the table starting at a different y position was my mistake and no bug. I misunderstood how the offset worked :)

Chemmic commented 2 months ago

Hey, Thank you for the review! I don't know what happened exactly, but I couldn't open the PDF as well, it was corrupted somehow. However, I uploaded a new PDF (working for me now at least)

vandeseer commented 2 months ago

Hey, Thank you for the review! I don't know what happened exactly, but I couldn't open the PDF as well, it was corrupted somehow. However, I uploaded a new PDF (working for me now at least)

  • Matteo

Hey Matteo,

the new PDF didn't work for me either, but that's not a big thing: I could produce it by running the test and that one worked correctly. I will simply replace it after I merged this PR.

Thanks again for your contribution! Let me know if you're interested in helping me maintaining this library – I'm open for it, since I don't want the project to die, but I really lack time to properly maintain it myself ...

Best, Stefan

Chemmic commented 2 months ago

Hey, Thank you for the review! I don't know what happened exactly, but I couldn't open the PDF as well, it was corrupted somehow. However, I uploaded a new PDF (working for me now at least)

  • Matteo

Hey Matteo,

the new PDF didn't work for me either, but that's not a big thing: I could produce it by running the test and that one worked correctly. I will simply replace it after I merged this PR.

Thanks again for your contribution! Let me know if you're interested in helping me maintaining this library – I'm open for it, since I don't want the project to die, but I really lack time to properly maintain it myself ...

Best, Stefan

Hey Stefan,

Sure, I'd be glad to help if I can! I'm currently working on my computer science bachelor's thesis, so I'll also be somewhat limited in time over the next few months as well. Feel free to contact me at Matteo.staar@gmx.de if there's anything that needs clarification or if I need to know something, like how the release process works or something like that :)

Best, Matteo