search

vandre / mojito

Mojito Chrome Extension for Mint
BSD 2-Clause "Simplified" License
44 stars 16 forks source link

Suggestion: Add foreign currency conversion for certain accounts #5

Open scottcwilson opened 9 years ago

scottcwilson commented 9 years ago

Mint supports foreign banks but doesn't do currency conversion. Would you be willing to either do this or accept my PR if I implemented it?

omidkrad commented 9 years ago

This is a good idea. However, for getting exchange rates, I know @vandre is very careful about the extension not talking to any outside domains for good reasons. This probably could be done by getting manual input for exchange rates in the settings page.

scottcwilson commented 9 years ago

Yes @omidkrad that was my plan - should have mentioned that.

vandre commented 9 years ago

I'm actually OK with calling an external domain for currency conversion, I could leverage something like YAHOO Finance API via JSONP. Something like this:

http://query.yahooapis.com/v1/public/yql?q=select%20*%20from%20yahoo.finance.xchange%20where%20pair%20in%20(%22USDMXN%22,%20%22USDEUR%22)&format=json&env=store://datatables.org/alltableswithkeys&callback=

What I'm not certain about is how to know which accounts/amounts need to be converted and to which currency. I don't think Mint provides this information in their API. One way to do it would be to create an screen similar to edit accounts and mark accounts as having a different currency and store those settings in localStorage, but is a bit of work

On Thu, Aug 27, 2015 at 12:31 PM, Scott C Wilson notifications@github.com wrote:

Yes @omidkrad https://github.com/omidkrad that was my plan - should have mentioned that.

— Reply to this email directly or view it on GitHub https://github.com/vandre/mojito/issues/5#issuecomment-135500909.

tallytalwar commented 7 years ago

Do you guys plan on any movement on this?