search

vanessa-kang / pe

0 stars 0 forks source link

Delete feature does not account for leading/trailing spaces in the index parameter #4

Open vanessa-kang opened 3 years ago

vanessa-kang commented 3 years ago

Within a trip, the delete feature for places and expenses does not account for leading/trailing spaces in the index parameter, even when the index entered is valid.

image.png

image.png

nus-pe-bot commented 3 years ago

Team's Response

Thank you for your report.

This is indeed a bug in our implementation. However, according to our UG, the command should not have any spaces after /e.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Thank you for acknowledging that it is a bug, however I disagree that it is not in scope. It should still be considered a bug as this is a scenario that could potentially happen during normal usage of the software, such as when the user makes a typo and accidentally includes additional spaces. But I do agree that it is low severity, since the input error has been rather gracefully handled.

Additionally, it has not been explicitly mentioned in the UG that “the command should not have any spaces after /e.” Here are screenshots of the relevant sections for reference:

image.png

image.png

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]